Is this really the first version? Please, use git-format-patch -vX. On Sat, Jul 03, 2021 at 05:07:54PM -0700, Hao Wu wrote: > This is a fix for the ATMEL TPM crash bug reported in > https://patchwork.kernel.org/project/linux-integrity/patch/20200926223150.109645-1-hao.wu@xxxxxxxxxx/ > > According to the discussions in the original thread, > we don't want to revert the timeout of wait_for_tpm_stat > for non-ATMEL chips, which brings back the performance cost. > For investigation and analysis of why wait_for_tpm_stat > caused the issue, and how the regression was introduced, > please read the original thread above. Please, no xrefs. Instead, describe what you are doing. > Thus the proposed fix here is to only revert the timeout > for ATMEL chips by checking the vendor ID. What do you mean by reverting? The long description needs a full rewrite. You can add Link: https://patchwork.kernel.org/project/linux-integrity/patch/20200926223150.109645-1-hao.wu@xxxxxxxxxx/ But do not expect anyone to read the thread in order to understand what the commit is doing. > Fixes: 9f3fc7bcddcb ("tpm: replace msleep() with usleep_range() in TPM 1.2/2.0 generic drivers") > Signed-off-by: Hao Wu <hao.wu@xxxxxxxxxx> > --- > Test Plan: > - Run fixed kernel with ATMEL TPM chips and see crash > has been fixed. > - Run fixed kernel with non-ATMEL TPM chips, and confirm > the timeout has not been changed. The changelog is missing. Please read section 14 of https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html /Jarkko
