... > > > + get_device(&chip->dev); > > > + chip->devs.release = tpm_devs_release; > > > + chip->devs.devt = > > > + MKDEV(MAJOR(tpm_devt), chip->dev_num + TPM_NUM_DEVICES); > > Isn't this less than 100 chars? Still best kept under 80 if 'reasonable'? Really it is just split in the wrong place: chip->devs.devt = MKDEV(MAJOR(tpm_devt), chip->dev_num + TPM_NUM_DEVICES); David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)