Re: [PATCH] tpm, tpm_tis: Acquire locality in tpm_tis_gen_interrupt() and tpm_get_timeouts()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 16, 2021 at 09:50:40AM +0100, Paul Menzel wrote:
> Dear Jarko,
> 
> 
> Am 16.02.21 um 09:39 schrieb Jarkko Sakkinen:
> > On Tue, Feb 16, 2021 at 09:26:49AM +0100, Paul Menzel wrote:
> 
> > > Am 16.02.21 um 09:17 schrieb Jarkko Sakkinen:
> > > > From: Lukasz Majczak <lma@xxxxxxxxxxxx>
> > > > 
> > > > This is shown with Samsung Chromebook Pro (Caroline) with TPM 1.2
> > > > (SLB 9670):
> > > > 
> > > > [    4.324298] TPM returned invalid status
> > > > [    4.324806] WARNING: CPU: 2 PID: 1 at drivers/char/tpm/tpm_tis_core.c:275 tpm_tis_status+0x86/0x8f
> > > > 
> > > > Background
> > > > ==========
> > > > 
> > > > TCG PC Client Platform TPM Profile (PTP) Specification, paragraph 6.1 FIFO
> > > > Interface Locality Usage per Register, Table 39 Register Behavior Based on
> > > > Locality Setting for FIFO - a read attempt to TPM_STS_x Registers returns
> > > > 0xFF in case of lack of locality. The described situation manifests itself
> > > > with the following warning trace:
> > > 
> > > Did you miss to paste the trace?
> > > 
> > > […]
> 
> > There is partial trace, which I took from the Lukasz patch. IMHO that is
> > sufficient.
> 
> Reading the paragraph with “ with the following warning trace:” (and colon),
> I would expect to see some trace, and not the next section header *The fix*.


Aah! I took the paragraph from the original commit. So, what if I just
remove the last sentence? I see what you mean.

> 
> > And I have no means to generate the full trace anyway.
> 
> No problem.
> 
> 
> Kind regards,
> 
> Paul
> 

/Jarkko



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux Kernel]     [Linux Kernel Hardening]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux