On Wed, Feb 10, 2021 at 08:12:19AM -0800, James Bottomley wrote: > On Wed, 2021-02-10 at 15:58 +0000, David Howells wrote: > > James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote: > > > > > keyctl add trusted kmk "new 32 > > > blobauth=f572d396fae9206628714fb2ce00f72e94f2258fkeyhandle=81000001 > > > " @u > > > > I presume there should be a space in there? > > Um, yes. My screen wraps at 80 characters which has keyhandle= > conveniently on the next line. > > James Please send a new revision. There was already two checkpatch errors I had to fix manually and also found 3rd issue when working with Sumit's patches: trusted-y += trusted_tpm2.o tpm2key.asn1.o Please line these up like trusted-y += trusted_tpm2.o trusted-y += tpm2key.asn1.o Is coherent with the line adding trusted_tpm1.o, and makes merging new features easier (e.g. TEE). I dropped current patches. /Jarkko
