Hi James, On 05.02.21 01:34, James Bottomley wrote: > > > Actually, this still isn't right. As I said to the last person who > reported this, we should be doing a get/put on the ops, not rolling our > own here: > > https://lore.kernel.org/linux-integrity/e7566e1e48f5be9dca034b4bfb67683b5d3cb88f.camel@xxxxxxxxxxxxxxxxxxxxx/ > Thanks for pointing this out, I was not aware of this discussion. > The reporter went silent before we could get this tested, but could you > try, please, because your patch is still hand rolling the ops get/put, > just slightly better than it had been done previously. I tested your patch and it fixes the issue. Your solution seems indeed much cleaner. FWIW: Tested-by: Lino Sanfilippo <l.sanfilippo@xxxxxxxxxx> Best Regards, Lino
