On Sat, 2021-01-30 at 22:40 +0200, Jarkko Sakkinen wrote: > On Thu, 2021-01-28 at 14:07 +0100, Lukasz Majczak wrote: > > There is a missing call to tpm_request_locality before the call to > > the tpm_get_timeouts() and tpm_tis_probe_irq_single(). As the current > > approach might work for tpm2, it fails for tpm1.x - in that case > > call to tpm_get_timeouts() or tpm_tis_probe_irq_single() > > without locality fails and in turn causes tpm_tis_core_init() to fail. > > Tested on Samsung Chromebook Pro (Caroline). > > > > Signed-off-by: Lukasz Majczak <lma@xxxxxxxxxxxx> > > Is it possible that you test against linux-next and see if any > problems still arise? I've applied the locality fixes from James. Also one nit: if any problems still persist, please add a snippet from klog to your commit message. /Jarkko
