On Sat, Jan 23, 2021 at 02:42:47AM +0100, Lukasz Majczak wrote: > There is a missing call to start_tpm_chip before the call to > the tpm_get_timeouts() and tpm_tis_probe_irq_single(). As the current > approach maight work for tpm2, it fails for tpm1.x - in that case > call to tpm_get_timeouts() or tpm_tis_probe_irq_single() tries to > transmit TPM commands on a disabled chip what what doesn't succeed > and in turn causes tpm_tis_core_init() to fail. > Tested on Samsung Chromebook Pro (Caroline). > > Signed-off-by: Lukasz Majczak <lma@xxxxxxxxxxxx> Do you have a log demonstrating the failure? /Jarkko
