James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote: > + *(data++) = _tagn(CONT, CONS, tag); You might want to move the _tag() and _tagn() macros into linux/asn1.h so that you don't need to include asn1_ber_bytecode.h. But apart from that: Reviewed-by: David Howells <dhowells@xxxxxxxxxx>