Hi Mimi,
> > > Nice! It works.
> > Thanks a lot for a testing?
> Yes, reviewed/tested together.
Sorry, I put question mark by accident, but thanks for confirmation anyway.
...
> When running these tests remotely, it helps to know which method of
> reading the PCRs is used. How about adding something like this to
> both instances of tpm2_pcr_supported()?
> if (imaevm_params.verbose > LOG_INFO)
> log_info("Using %s to read PCRs.\n", CMD);
+1
> > Shell I post v2 or you amend my patch?
> Either way is fine.
Sending v2 in a minute. Feel free to amend it to suit your needs.
> > BTW I was thinking to create custom function / macro for handling errmsg to
> > reduce duplicity.
> Sure, I assume that would be in addition to log_err() and log_errno().
I'll probably postpone this cleanup after this patchset is merged (unless you do
the cleanup yourself). It can even wait after the release, I don't want to block
release with minor cleanup.
> > + there is minor warning on newer gcc, I'm not sure how to fix that:
> > evmctl.c: In function ‘read_tpm_banks’:
> > evmctl.c:1404:25: warning: ‘%2.2d’ directive writing between 2 and 10 bytes into a region of size 3 [-Wformat-overflow=]
> > 1404 | sprintf(pcr_str, "PCR-%2.2d", i);
> > | ^~~~~
> > evmctl.c:1404:20: note: directive argument in the range [0, 2147483647]
> > 1404 | sprintf(pcr_str, "PCR-%2.2d", i);
> > | ^~~~~~~~~~~
> > evmctl.c:1404:3: note: ‘sprintf’ output between 7 and 15 bytes into a destination of size 7
> > 1404 | sprintf(pcr_str, "PCR-%2.2d", i);
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Interesting. Checking that "i" isn't greater than 99 solves this
> warning. Changing pcr_str size from 7 to 8 solves the other warning.
Nice, how simple. I wasn't sure myself about changing of the array size.
Feel free to just fix it.
Kind regards,
Petr
