On Tue, 2020-07-14 at 17:46 +0200, Petr Vorel wrote:
> instead of checking in build time as it's runtime dependency.
> Also log when tsspcrread not found to make debugging easier.
>
> We search for tsspcrread unless there is tss2-esys with Esys_PCR_Read(),
> thus pcr_none.c was dropped as unneeded.
>
> file_exist(), file_exist() and MIN() taken from LTP project.
One of these "file_exists" I assume is suppose to be "tst_get_path".
>
> Signed-off-by: Petr Vorel <pvorel@xxxxxxx>
> ---
> Hi Mimi,
>
> small improvement based on the current next-testing branch
> (9638068aff2476b567185d7eb94126449ad89ca7).
>
> I'm sorry I don't have the required setup, thus didn't test this patch.
>
> Kind regards,
> Petr
Nice! It works.
> diff --git a/src/pcr_tsspcrread.c b/src/pcr_tsspcrread.c
> @@ -47,8 +48,21 @@
>
> #include "utils.h"
>
> -int tpm2_pcr_supported(void)
> +#define CMD "tsspcrread"
> +
> +static char path[PATH_MAX];
> +
> +int tpm2_pcr_supported(char **errmsg)
> {
> + int ret;
> +
> + if (get_cmd_path(CMD, path, sizeof(path))) {
> + ret = asprintf(errmsg, "Couldn't find '%s' in $PATH", CMD);
> + if (ret == -1) /* the contents of errmsg is undefined */
> + *errmsg = NULL;
> + return 0;
> + }
> +
Any chance you could also emit the pathname on success as well?
> return 1;
> }
