Mimi,
On Mon, Mar 23, 2020 at 10:23:42AM -0400, Mimi Zohar wrote:
>
> I really appreciate your creating this set of tests! However, when
> you first posted this patch, I asked you to break it up into more
> manageable pieces to review. I understand this isn't the Linux
> kernel, "just" some tests, but there is good reason that the Linux
> kernel development requires large patches be broken up into more
> manageable small, logical changes.
>
> I've recently asked a few people to help review this patch. I
> understand that it is a lot of work to break this patch up into
> smaller patches, but it will simplify review.
>
> If I was to break up this patch, I would start by making the test
> driver and each of the tests a separate patch. The test driver patch
> description should reference the GNU documentation, with an
> explanation as to why a custom driver is preferred[1].
I don't use custom driver. Default simple driver is used, I think it's
called "Parallel Test Harness".
There is only two tests - ima_hash and sign_verify. ima_hash tests
ima_hash evmctl command making ima hashes and verifying them;
sign_verify tests {ima_,}{sign,verify} commands making signatures and
verifying them. (They are tested together, because they are related
(verify need sign first, evm sign can produce ima signature too) and
can verify each other).
Thanks,
