Re: [PATCH v7] ima-evm-utils: Add some tests for evmctl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Vitaly,

I really appreciate your creating this set of tests!  However, when
you first posted this patch, I asked you to break it up into more
manageable pieces to review.  I understand this isn't the Linux
kernel, "just" some tests, but there is good reason that the Linux
kernel development requires large patches be broken up into more
manageable small, logical changes.

I've recently asked a few people to help review this patch.  I
understand that it is a lot of work to break this patch up into
smaller patches, but it will simplify review.

If I was to break up this patch, I would start by making the test
driver and each of the tests a separate patch.  The test driver patch
description should reference the GNU documentation, with an
explanation as to why a custom driver is preferred[1].

thanks,

Mimi

[1] https://www.gnu.org/software/automake/manual/html_node/Generalitie
s-about-Testing.html#Generalities-about-Testing




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux Kernel]     [Linux Kernel Hardening]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux