On 3/10/20 11:45 AM, Waiman Long wrote: > On 3/9/20 12:32 PM, David Howells wrote: >> Waiman Long <longman@xxxxxxxxxx> wrote: >> >>> + tmpbuf = kmalloc(tbuflen, GFP_KERNEL); >> This would probably be better off using kvmalloc() - otherwise big objects >> have to be constructed from runs of contiguous pages. But since all we're >> doing is buffering for userspace, we don't care about that. >> >> If you agree, we can address it with an additional patch. >> >> David > That is certainly fine with me. I don't care if the pages are contiguous > or not. Will add a patch 3 for that as suggested. That is not as simple as I thought. First of that, there is not an equivalent kzvfree() helper to clear the buffer first before clearing. Of course, I can do that manually. With patch 2, the allocated buffer length will be max(1024, keylen). The security code uses kmalloc() for allocation. If we use kvalloc() here, perhaps we should also use that for allocation that can be potentially large like that in big_key. What do you think? Cheers, Longman
