Waiman Long <longman@xxxxxxxxxx> wrote: > + tmpbuf = kmalloc(tbuflen, GFP_KERNEL); This would probably be better off using kvmalloc() - otherwise big objects have to be constructed from runs of contiguous pages. But since all we're doing is buffering for userspace, we don't care about that. If you agree, we can address it with an additional patch. David