On Mon, 2020-02-10 at 08:40 -0800, Lakshmi Ramasubramanian wrote: > On 2/9/20 6:46 PM, Joe Perches wrote: > > > > In addition, as Shuah Khan suggested for the security/integrity/ > > > directory, "there is an opportunity here to add #define pr_fmt(fmt) > > > KBUILD_MODNAME ": " fmt to integrity.h and get rid of duplicate > > > defines." > > Good point - we'll make that change. > > With Joe Perches patch (waiting for it to be re-posted), > > > are all the pr_fmt definitions needed in each file in the > > > integrity/ima directory? > > > > btw Tushar and Lakshmi: > > > > I am not formally submitting a patch here. > > > > I was just making suggestions and please do > > with it as you think appropriate. > > Joe - it's not clear to me what you are suggesting. > We'll move the #define for pr_fmt to integrity.h. > > What's other changes are you proposing? https://lore.kernel.org/lkml/4b4ee302f2f97e3907ab03e55a92ccd46b6cf171.camel@xxxxxxxxxxx/