On 2/9/20 6:46 PM, Joe Perches wrote:
In addition, as Shuah Khan suggested for the security/integrity/
directory, "there is an opportunity here to add #define pr_fmt(fmt)
KBUILD_MODNAME ": " fmt to integrity.h and get rid of duplicate
defines."
Good point - we'll make that change.
With Joe Perches patch (waiting for it to be re-posted),
are all the pr_fmt definitions needed in each file in the
integrity/ima directory?
btw Tushar and Lakshmi:
I am not formally submitting a patch here.
I was just making suggestions and please do
with it as you think appropriate.
Joe - it's not clear to me what you are suggesting.
We'll move the #define for pr_fmt to integrity.h.
What's other changes are you proposing?
out:
+ if (ret < 0)
+ pr_err("Process buffer measurement failed, result: %d\n",
+ ret);
There's no reason to split the statement like this. The joined line
is less than 80 characters.
Agree.
thanks,
-lakshmi
