Mimi, On Thu, Jun 20, 2019 at 09:40:49AM -0400, Mimi Zohar wrote: > On Thu, 2019-06-20 at 09:21 -0400, Mimi Zohar wrote: > > > > > > If so, why are there other changes in this patch? > > > > > > > > > > There is no other changes beside stated in description. > > > > > > > > Are the changes from read_pub_key() to read_pub_pkey() and > > > > calc_keyid_v2() to calc_pkeyid_v2() needed for making find_keyid() a > > > > wrapper for find_keyid_pkey()? > > > > > > Of course. `entry->key' now have different type. If we keep old type > > > (RSA) where will be nothing to wrap. > > > > The question wasn't if the changes in init_public_keys() need to be > > made, the question is its correlation to find_keyid(). Unlesss I'm > > missing something, find_keyid() is only called by verify_hash_v2(), > > not calc_keyid_v2(). > > Ah, the list of keys needs to be in the appropriate format. Perhaps > add that info in the patch description. Isn't this is implied by find_keyid()? It finds appropriate `entry->key', and it's type is changed to EVP_PKEY, so both init_public_keys() (where it fills `entry->key`) and find_keyid() (where it returns `entry->key`) need to be changed. Vitaly.
