> On Feb 11, 2019, at 11:42 AM, Borislav Petkov <bp@xxxxxxxxx> wrote: > > On Mon, Feb 11, 2019 at 11:27:03AM -0800, Nadav Amit wrote: >> Is there any comment over static_cpu_has()? ;-) > > Almost: > > /* > * Static testing of CPU features. Used the same as boot_cpu_has(). > * These will statically patch the target code for additional > * performance. > */ > static __always_inline __pure bool _static_cpu_has(u16 bit) Oh, I missed this comment. BTW: the “__pure” attribute is useless when “__always_inline” is used. Unless it is intended to be some sort of comment, of course.