On Thu, Jan 24, 2019 at 04:49:04PM +0100, Roberto Sassu wrote:
> + chip->allocated_banks = kcalloc(1, sizeof(*chip->allocated_banks),
> + GFP_KERNEL);
> + if (!chip->allocated_banks) {
> + rc = -ENOMEM;
> + goto out;
> + }
> +
> + chip->allocated_banks[0] = TPM2_ALG_SHA1;
> + chip->nr_allocated_banks = 1;
Everything else looks nice in this patch except this.
You always branch for TPM 1.2, and it will always have just SHA1. This
is unnecessary.
/Jarkko
