On Tue, Jan 29, 2019 at 10:41:45AM -0700, Jerry Snitselaar wrote: > Set tpm_chip->timeouts_adjusted directly in the update_timeouts > code instead of returning bool. Return rc of tpm read instead, > which can be return an error in the case of the spi driver. > > Signed-off-by: Jerry Snitselaar <jsnitsel@xxxxxxxxxx> Couple of remarks: 1. Shouldn't it then be just void? 2. Why do we even need timeout_adjusted in struct tpm_chip [1]? [1] Only used locally in tpm1_get_timeouts(). /Jarkko
