On Sun, Dec 02, 2018 at 10:29:26AM -0800, James Bottomley wrote: > The distros won't thank you for yet another kconfig option. , > especially one which could cause regressions if they choose the wrong > value. However, having a hidden one which could be activated by driver > might work ... on the other hand almost all the current drivers support > both 1.2 and 2.0 so they'd all need splitting. By default on (i.e. have TPM 1.x) and with a well thought documentation should not be too bad. > The other thing that should give us pause is this: > > jejb@jarvis:~/git/linux/drivers/char/tpm> size tpm.o > text data bss dec hex > filename > 35247 1120 32 36399 8e2f > tpm.o > > Currently the combined tpm subsystem (without drivers) is less than 36k > of code, so is splitting it up valuable? I think you're going to find > we have a reasonable abstraction of sharing, so taking out 1.x by > config will likely save less than 10k of code ... is that worth the > effort? It is not only a size question. All unused code is always potential attack surface. If the option is by default off and properly documented, it should be IMHO ok. It is fairly easy to do as TPM 1.x commands have been already put into their own file thanks to Tomas. /Jarkko
