On Tue, Oct 02, 2018 at 04:58:25AM +0000, Winkler, Tomas wrote: > > > > > > On Sat, Sep 29, 2018 at 01:30:26AM +0300, Tomas Winkler wrote: > > > Add tpm2_pcr_extend() function to tpm2-cmd.c with signature required > > > by tpm-interface.c. It wraps the original open code implementation. > > > The original original tpm2_pcr_extend() function is renamed to > > > __tpm2_pcr_extend() and made static, it is called only from new > > > tpm2_pcr_extend(). > > > > > > Fix warnings in __tpm2_pcr_extend() > > > tpm2-cmd.c:251:16: warning: comparison between signed and unsigned > > > integer expressions [-Wsign-compare] > > > tpm2-cmd.c:252:17: warning: comparison between signed and unsigned > > > integer expressions [-Wsign-compare] > > > > > > Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx> > > > > We do not want the signature change, especially because as we are working > > on getting Roberto's changes in and also because it has absolutely a zero > > gain. Who cares if those functions take different parameters? I don't. > > Yes, we do care this series tries to have a clean cut between 1.x and 2.x specs. Please, let's finish one transformation and then move to another. > I understand that Roberto will have to rebase anyhow, if this series goes in first, if this is hard I can do it myself, it's trivial. > > Tomas I'm happy to tune this minor stuff. I'll wait for Nayna to test the one patch and make those adjustments :-) Would not make sense to roll another series for these changes. /Jarkko
