On Mon, Nov 20, 2017 at 09:19:37PM +0000, Shaikh, Azhar wrote: > -> tpm_tis_core_init() Yes, and IIRC, this covers tpm_tis_update_timeouts() too? > -> tpm_tis_plat_remove() This should be in tpm_tis_remove and a little rework would be needed here > -> tpm_tis_reenable_interrupts() > -> tpm_transmit_cmd() [ Already implemented in this patch ] Yes > >You could add a debug to ensure that read/write is never without clk_enable > >being held. > > Sorry, but I didn't get this, adding a debug part. Just check a flag in the read/write functions to see if clkrun is on and WARN if not Not sure if this is going to be overall better than what you have or not.. But considering the nature of the bug it seems safer to have a wider range when CLKRUN is working? Jason
