On Mon, Nov 20, 2017 at 06:52:13PM +0000, Shaikh, Azhar wrote: > We want to have the CLKRUN disabled for any/all TPM transactions. > The clk_toggle handles only the case while a TPM command is being > sent and received. We have to take into consideration other places > too where TPM access is happening outside the TPM command flow. For > eg: request_locality, check_locality, release_locality, wait_startup > which might be called outside the flow of a TPM command. Okay, this makes sense, and would be good to touch on in the commit description if it stays this way, IMHO. However, why not have check_locality, release_locality, wait_startup use clk_toggle instead? That seems better to me?? > Will change it to clk_enable. Should I then upload the next patch > for review and remove the "RFC" tag now? And if so, should I retain > the change history of the patch versions? Yes for both. I think we are well past the RFC stage now :) Jason
