On Tue, Oct 17, 2017 at 02:03:02PM +0300, Andy Shevchenko wrote: > On Mon, 2017-10-16 at 19:33 +0200, SF Markus Elfring wrote: > > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > > Date: Mon, 16 Oct 2017 18:28:17 +0200 > > > > Replace the specification of data structures by pointer dereferences > > as the parameter for the operator "sizeof" to make the corresponding > > size > > determination a bit safer according to the Linux coding style > > convention. > > > This patch does one style in favor of the other. > > At the end it's Jarkko's call, though I would NAK this as I think some > one already told this to you for some other similar patch(es). > > > I even would suggest to stop doing this noisy stuff, which keeps people > busy for nothing. I favor using "sizeof(*foo)" for pointers but as a part of a commit where something useful is done to the corresponding line of code. So, I would say it's a NAK. /Jarkko
