On Mon, 2017-10-16 at 19:33 +0200, SF Markus Elfring wrote: > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Mon, 16 Oct 2017 18:28:17 +0200 > > Replace the specification of data structures by pointer dereferences > as the parameter for the operator "sizeof" to make the corresponding > size > determination a bit safer according to the Linux coding style > convention. This patch does one style in favor of the other. At the end it's Jarkko's call, though I would NAK this as I think some one already told this to you for some other similar patch(es). I even would suggest to stop doing this noisy stuff, which keeps people busy for nothing. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > --- > drivers/char/tpm/st33zp24/i2c.c | 3 +-- > drivers/char/tpm/st33zp24/spi.c | 3 +-- > drivers/char/tpm/st33zp24/st33zp24.c | 3 +-- > drivers/char/tpm/tpm_crb.c | 2 +- > drivers/char/tpm/tpm_i2c_atmel.c | 2 +- > drivers/char/tpm/tpm_i2c_nuvoton.c | 2 +- > drivers/char/tpm/tpm_ibmvtpm.c | 2 +- > drivers/char/tpm/tpm_tis.c | 2 +- > drivers/char/tpm/tpm_tis_spi.c | 3 +-- > 9 files changed, 9 insertions(+), 13 deletions(-) > > diff --git a/drivers/char/tpm/st33zp24/i2c.c > b/drivers/char/tpm/st33zp24/i2c.c > index be5d1abd3e8e..d0cb25688485 100644 > --- a/drivers/char/tpm/st33zp24/i2c.c > +++ b/drivers/char/tpm/st33zp24/i2c.c > @@ -245,8 +245,7 @@ static int st33zp24_i2c_probe(struct i2c_client > *client, > return -ENODEV; > } > > - phy = devm_kzalloc(&client->dev, sizeof(struct > st33zp24_i2c_phy), > - GFP_KERNEL); > + phy = devm_kzalloc(&client->dev, sizeof(*phy), GFP_KERNEL); > if (!phy) > return -ENOMEM; > > diff --git a/drivers/char/tpm/st33zp24/spi.c > b/drivers/char/tpm/st33zp24/spi.c > index 0fc4f20b5f83..c952df9244c8 100644 > --- a/drivers/char/tpm/st33zp24/spi.c > +++ b/drivers/char/tpm/st33zp24/spi.c > @@ -358,8 +358,7 @@ static int st33zp24_spi_probe(struct spi_device > *dev) > return -ENODEV; > } > > - phy = devm_kzalloc(&dev->dev, sizeof(struct > st33zp24_spi_phy), > - GFP_KERNEL); > + phy = devm_kzalloc(&dev->dev, sizeof(*phy), GFP_KERNEL); > if (!phy) > return -ENOMEM; > > diff --git a/drivers/char/tpm/st33zp24/st33zp24.c > b/drivers/char/tpm/st33zp24/st33zp24.c > index 4d1dc8b46877..0686a129268c 100644 > --- a/drivers/char/tpm/st33zp24/st33zp24.c > +++ b/drivers/char/tpm/st33zp24/st33zp24.c > @@ -533,8 +533,7 @@ int st33zp24_probe(void *phy_id, const struct > st33zp24_phy_ops *ops, > if (IS_ERR(chip)) > return PTR_ERR(chip); > > - tpm_dev = devm_kzalloc(dev, sizeof(struct st33zp24_dev), > - GFP_KERNEL); > + tpm_dev = devm_kzalloc(dev, sizeof(*tpm_dev), GFP_KERNEL); > if (!tpm_dev) > return -ENOMEM; > > diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c > index 7b3c2a8aa9de..343c46e8560f 100644 > --- a/drivers/char/tpm/tpm_crb.c > +++ b/drivers/char/tpm/tpm_crb.c > @@ -557,7 +557,7 @@ static int crb_acpi_add(struct acpi_device > *device) > if (sm == ACPI_TPM2_MEMORY_MAPPED) > return -ENODEV; > > - priv = devm_kzalloc(dev, sizeof(struct crb_priv), > GFP_KERNEL); > + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > if (!priv) > return -ENOMEM; > > diff --git a/drivers/char/tpm/tpm_i2c_atmel.c > b/drivers/char/tpm/tpm_i2c_atmel.c > index 95ce2e9ccdc6..2d0df930a76d 100644 > --- a/drivers/char/tpm/tpm_i2c_atmel.c > +++ b/drivers/char/tpm/tpm_i2c_atmel.c > @@ -165,7 +165,7 @@ static int i2c_atmel_probe(struct i2c_client > *client, > if (IS_ERR(chip)) > return PTR_ERR(chip); > > - priv = devm_kzalloc(dev, sizeof(struct priv_data), > GFP_KERNEL); > + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > if (!priv) > return -ENOMEM; > > diff --git a/drivers/char/tpm/tpm_i2c_nuvoton.c > b/drivers/char/tpm/tpm_i2c_nuvoton.c > index c6428771841f..5983d52eb6d9 100644 > --- a/drivers/char/tpm/tpm_i2c_nuvoton.c > +++ b/drivers/char/tpm/tpm_i2c_nuvoton.c > @@ -551,7 +551,7 @@ static int i2c_nuvoton_probe(struct i2c_client > *client, > if (IS_ERR(chip)) > return PTR_ERR(chip); > > - priv = devm_kzalloc(dev, sizeof(struct priv_data), > GFP_KERNEL); > + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > if (!priv) > return -ENOMEM; > > diff --git a/drivers/char/tpm/tpm_ibmvtpm.c > b/drivers/char/tpm/tpm_ibmvtpm.c > index b18148ef2612..a4b462a77b99 100644 > --- a/drivers/char/tpm/tpm_ibmvtpm.c > +++ b/drivers/char/tpm/tpm_ibmvtpm.c > @@ -608,7 +608,7 @@ static int tpm_ibmvtpm_probe(struct vio_dev > *vio_dev, > if (IS_ERR(chip)) > return PTR_ERR(chip); > > - ibmvtpm = kzalloc(sizeof(struct ibmvtpm_dev), GFP_KERNEL); > + ibmvtpm = kzalloc(sizeof(*ibmvtpm), GFP_KERNEL); > if (!ibmvtpm) > goto cleanup; > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c > index ebd0e75a3e4d..0a3af60bab2a 100644 > --- a/drivers/char/tpm/tpm_tis.c > +++ b/drivers/char/tpm/tpm_tis.c > @@ -294,7 +294,7 @@ static int tpm_tis_init(struct device *dev, struct > tpm_info *tpm_info) > if (rc) > return rc; > > - phy = devm_kzalloc(dev, sizeof(struct tpm_tis_tcg_phy), > GFP_KERNEL); > + phy = devm_kzalloc(dev, sizeof(*phy), GFP_KERNEL); > if (phy == NULL) > return -ENOMEM; > > diff --git a/drivers/char/tpm/tpm_tis_spi.c > b/drivers/char/tpm/tpm_tis_spi.c > index 424ff2fde1f2..7cabb12d0b3a 100644 > --- a/drivers/char/tpm/tpm_tis_spi.c > +++ b/drivers/char/tpm/tpm_tis_spi.c > @@ -200,8 +200,7 @@ static int tpm_tis_spi_probe(struct spi_device > *dev) > { > struct tpm_tis_spi_phy *phy; > > - phy = devm_kzalloc(&dev->dev, sizeof(struct tpm_tis_spi_phy), > - GFP_KERNEL); > + phy = devm_kzalloc(&dev->dev, sizeof(*phy), GFP_KERNEL); > if (!phy) > return -ENOMEM; > -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy