On Sun, Feb 23, 2025 at 10:47 PM Aditya Garg <gargaditya08@xxxxxxxx> wrote: > Could you see this patch btw. It also addresses some minor code style issues in the driver. Each patch should do one small thing. Style issues in unrelated code should be addressed in separate patches. > + if (strncmp(hdev->name, non_apple, strlen(non_apple)) == 0 && This will match any keyboard whose name starts with "Bluetooth Keyboard", instead of keyboards whose names are exactly "Bluetooth Keyboard". A name such as "Bluetooth Keyboard 16" is only possible if the keyboard is a real Apple keyboard that has been renamed in Mac OS, which means that it is not an Omoton. All in all, the general idea of having a table like in your patch is not a bad idea, but like I said in my previous email, it seems superfluous at this point in time. -Alex
