Re: [PATCH v11 3/9] dt-bindings: power: supply: max17042: split on 2 files

[Dzmitry Sankouski <dsankouski@xxxxxxxxx>]

вт, 10 дек. 2024 г. в 10:38, Krzysztof Kozlowski <krzk@xxxxxxxxxx>:
>
> On Mon, Dec 09, 2024 at 02:26:27PM +0300, Dzmitry Sankouski wrote:
> > Move max17042 common binding part to separate file, to
> > reuse it for MFDs with platform driver version.
> >
> > Signed-off-by: Dzmitry Sankouski <dsankouski@xxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/power/supply/maxim,max17042-base.yaml | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml      | 49 +------------------------------------------------
> >  MAINTAINERS                                                             |  2 +-
> >  3 files changed, 68 insertions(+), 49 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max17042-base.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max17042-base.yaml
> > new file mode 100644
> > index 000000000000..1653f8ae11f7
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/supply/maxim,max17042-base.yaml
> > @@ -0,0 +1,66 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/power/supply/maxim,max17042-base.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Maxim 17042 fuel gauge series
> > +
> > +maintainers:
> > +  - Sebastian Reichel <sre@xxxxxxxxxx>
> > +
> > +allOf:
> > +  - $ref: power-supply.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - maxim,max17042
> > +      - maxim,max17047
> > +      - maxim,max17050
> > +      - maxim,max17055
> > +      - maxim,max77705-battery
> > +      - maxim,max77849-battery
>
> Shared schemas define only shared properties, not compatibles. But the
> main problem is you did not answer nor resolve my previous concerns -
> either this device has separate address and probably is a separate
> device on the same or different bus.
>
> Plus this was not tested and does not really work, but anyway let's
> focus on my previous concerns first.
>

Ah, indeed, the device tree in this and previous patches doesn't
reflect hardware wiring.

MAX77705 fuel gauge has a separate i2c address, i.e. I may move it out of the
MAX77705 MFD node. However, the device on that address has additional features,
like measuring system and input current, which is out of fuel gauge
responsibility.

So I guess I should create another MFD for fuel gauge, i. e. max77705 example
would look like:

...
  pmic@66 {
    compatible = "maxim,max77705";
...
  };

  meter@36 {
    compatible = "maxim,max77705-meter";

    // max17042 fuel gauge driver in platform mode
    fuel-gauge {
      power-supplies = <&max77705_charger>;
      maxim,rsns-microohm = <5000>;
      interrupt-parent = <&pm8998_gpios>;
      interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
    };
  };

-- 
Best regards and thanks for review,
Dzmitry