On Mon, Dec 09, 2024 at 02:26:27PM +0300, Dzmitry Sankouski wrote: > Move max17042 common binding part to separate file, to > reuse it for MFDs with platform driver version. > > Signed-off-by: Dzmitry Sankouski <dsankouski@xxxxxxxxx> > --- > Documentation/devicetree/bindings/power/supply/maxim,max17042-base.yaml | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml | 49 +------------------------------------------------ > MAINTAINERS | 2 +- > 3 files changed, 68 insertions(+), 49 deletions(-) > > diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max17042-base.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max17042-base.yaml > new file mode 100644 > index 000000000000..1653f8ae11f7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/maxim,max17042-base.yaml > @@ -0,0 +1,66 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/supply/maxim,max17042-base.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Maxim 17042 fuel gauge series > + > +maintainers: > + - Sebastian Reichel <sre@xxxxxxxxxx> > + > +allOf: > + - $ref: power-supply.yaml# > + > +properties: > + compatible: > + enum: > + - maxim,max17042 > + - maxim,max17047 > + - maxim,max17050 > + - maxim,max17055 > + - maxim,max77705-battery > + - maxim,max77849-battery Shared schemas define only shared properties, not compatibles. But the main problem is you did not answer nor resolve my previous concerns - either this device has separate address and probably is a separate device on the same or different bus. Plus this was not tested and does not really work, but anyway let's focus on my previous concerns first. > + > + interrupts: > + maxItems: 1 > + description: | > + The ALRT pin, an open-drain interrupt. ... > + > +additionalProperties: false > + > diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml > index 14242de7fc08..b7fd714cc72e 100644 > --- a/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml > +++ b/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml > @@ -10,60 +10,13 @@ maintainers: > - Sebastian Reichel <sre@xxxxxxxxxx> > > allOf: > - - $ref: power-supply.yaml# > + - $ref: maxim,max17042-base.yaml# > > properties: > - compatible: > - enum: > - - maxim,max17042 > - - maxim,max17047 > - - maxim,max17050 > - - maxim,max17055 > - - maxim,max77705-battery > - - maxim,max77849-battery > - This does not make sense. Final device schema must come with compatibles. Best regards, Krzysztof
