On Sun, Nov 17, 2024 at 11:06:27PM +0100, Marek Vasut wrote: > On 11/17/24 4:34 AM, Kees Cook wrote: > > Commit 781a07da9bb9 ("Input: ads7846 - add dummy command register > > clearing cycle") added commands to struct ser_req::xfer without > > expanding it to hold them. Expand the array to the correct size. > > > > ../drivers/input/touchscreen/ads7846.c: In function 'ads7846_read12_ser': > > ../drivers/input/touchscreen/ads7846.c:416:18: error: array subscript 7 is above array bounds of 'struct spi_transfer[6]' [-Werror=array-bounds=] > > 416 | req->xfer[7].rx_buf = &req->scratch; > > | ~~~~~~~~~^~~ > > ../drivers/input/touchscreen/ads7846.c:334:33: note: while referencing 'xfer' > > 334 | struct spi_transfer xfer[6]; > > | ^~~~ > > > > Fixes: 781a07da9bb9 ("Input: ads7846 - add dummy command register clearing cycle") > > Signed-off-by: Kees Cook <kees@xxxxxxxxxx> > I think Nathan already sent a fix too. Oh excellent! I did a search in lore before sending it but must have failed to find it. Do you have a link to it? -Kees -- Kees Cook