Hi, Yes, Samsung likely developed custom firmware based on the Firmware Development Kit (FDK) provided by Inteland signed it. When the firmware is loaded and the file is detected to be incorrect, it will print the log “[ 4.430675] intel_ish_ipc 0000:00:12.0: ISH loader: cmd 2 failed 10”. The vendor can upstream their firmware binary to linux-firmware.git according to the naming rules mentioned in https://docs.kernel.org/hid/intel-ish-hid.html#vendor-custom-firmware-loading. Thanks, Lixu >-----Original Message----- >From: melvyn <melvyn2@xxxxxxxxxxx> >Sent: Sunday, November 17, 2024 1:32 AM >To: srinivas pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>; linux- >input@xxxxxxxxxxxxxxx >Cc: jikos@xxxxxxxxxx; Zhang, Lixu <lixu.zhang@xxxxxxxxx> >Subject: Re: intel_ish_ipc: loader failure on Lunar Lake > >This was correct, I missed the "ISH extension" driver on windows which >provided a different ISH firmware. Loading it on linux renders these sensors >fully working. > >Unfortunately, I couldn't find any license information apart from the "INTEL >PROPRIETARY" header in the INF file, which Samsung probably just left from >the Intel-provided extension template; the firmware probably can't be >upstreamed without vendor cooperation (unlikely here). > >Thank you for the assistance! > >-melvyn2 > >On 11/16/24 09:45, srinivas pandruvada wrote: >> Hi, >> >> + Lixu >> >> It is likely that Samsung needs their own firmware. >> >> Thanks, >> Srinivas >> >> On Fri, 2024-11-15 at 15:18 -0500, melvyn wrote: >>> Totally missed to CC the maintainers, sorry! >>> >>> -melvyn2 >>> >>> On 11/7/24 21:42, melvyn wrote: >>>> Hello, >>>> >>>> The intel_ish_ipc driver seems to fail on my machine. It's a >>>> lunar-lake based convertible (samsung galaxy book5 ...) which should >>>> provide accelerometer/gyroscope/lid tild HID inputs. These work on >>>> Windows fully, but do not appear to work on 6.12rc5. All I have to >>>> go on are the following kernel log lines: >>>> >>>> ... >>>> [ 4.416718] intel_ish_ipc 0000:00:12.0: ISH loader: load >>>> firmware: >>>> intel/ish/ish_lnlm.bin >>>> [ 4.430675] intel_ish_ipc 0000:00:12.0: ISH loader: cmd 2 failed >>>> 10 >>>> [ 4.448263] intel_ish_ipc 0000:00:12.0: ISH loader: cmd 2 failed >>>> 10 >>>> [ 4.467844] intel_ish_ipc 0000:00:12.0: ISH loader: cmd 2 failed >>>> 10 >>>> ... >>>> >>>> The kernel is very close to mainline (NixOS's linux-testing) and >>>> doesn't seem to have any patches which would affect this driver >>>> specifically. >>>> >>>> If there's any further information I can collect please let me know. >>>> It's my first time trying to use a kernel mailing list, so apologies >>>> if this is the wrong place or I'm missing something else. >>>> >>>> Thank you, >>>> >>>> melvyn2