In error handling code for "no such device" or memory already used, release the mutex before to return. Found with Coccinelle static analisys tool, script: https://coccinelle.gitlabpages.inria.fr/website/rules/mut.cocci Signed-off-by: Alessandro Zanni <alessandro.zanni87@xxxxxxxxx> --- drivers/input/mouse/psmouse-base.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/input/mouse/psmouse-base.c b/drivers/input/mouse/psmouse-base.c index 5a4defe9cf32..cb3a125d8d7c 100644 --- a/drivers/input/mouse/psmouse-base.c +++ b/drivers/input/mouse/psmouse-base.c @@ -1930,11 +1930,13 @@ static ssize_t psmouse_attr_set_protocol(struct psmouse *psmouse, void *data, co if (serio->drv != &psmouse_drv) { input_free_device(new_dev); + mutex_unlock(&psmouse_mutex); return -ENODEV; } if (psmouse->protocol == proto) { input_free_device(new_dev); + mutex_unlock(&psmouse_mutex); return count; /* switched by other thread */ } } -- 2.43.0
