Re: [PATCH v2 08/12] can: lin: Add special frame id for rx offload config

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2024-05-02 at 12:27 +0200, Krzysztof Kozlowski wrote:
> On 02/05/2024 09:55, Christoph Fritz wrote:
> > A LIN bus supports up to 64 identifiers in one byte. This commit adds a
> > special frame ID, beyond the actual LIN identifiers, for signaling RX
> > offload configuration requests. This ID will be utilized in future LIN
> > enhancements to the CAN broadcast manager.
> > 
> > Signed-off-by: Christoph Fritz <christoph.fritz@xxxxxxxxx>
> > ---
> >  include/net/lin.h | 1 +
> 
> You just added this file in other patch. What is the point of splitting
> line-per-line additions?

My intention was to make the review process easier by separating the
BCM (Broadcast Manager) logic from the basic driver implementation.

> There is no user of this in this patch. Squash it with the patch adding
> the file.

OK

v3 is coming up

Thanks
  -- Christoph





[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux