Hi Jonathan, kernel test robot noticed the following build warnings: [auto build test WARNING on dtor-input/next] [also build test WARNING on dtor-input/for-linus hid/for-next linus/master v6.9-rc6 next-20240502] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jonathan-Denose/Input-elantech-fix-touchpad-state-on-resume-for-Lenovo-N24/20240501-220739 base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next patch link: https://lore.kernel.org/r/20240501140231.1.Ifa0e25ebf968d8f307f58d678036944141ab17e6%40changeid patch subject: [PATCH] Input: elantech - fix touchpad state on resume for Lenovo N24 config: arm-defconfig (https://download.01.org/0day-ci/archive/20240503/202405030159.u9nJS35h-lkp@xxxxxxxxx/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240503/202405030159.u9nJS35h-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202405030159.u9nJS35h-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> drivers/input/mouse/elantech.c:1509:61: warning: incompatible pointer to integer conversion passing 'void *' to parameter of type 'unsigned int' [-Wint-conversion] err = ps2_sendbyte(&psmouse->ps2dev, PSMOUSE_CMD_DISABLE, NULL); ^~~~ include/linux/stddef.h:8:14: note: expanded from macro 'NULL' #define NULL ((void *)0) ^~~~~~~~~~~ include/linux/libps2.h:64:63: note: passing argument to parameter 'timeout' here int ps2_sendbyte(struct ps2dev *ps2dev, u8 byte, unsigned int timeout); ^ drivers/input/mouse/elantech.c:1515:60: warning: incompatible pointer to integer conversion passing 'void *' to parameter of type 'unsigned int' [-Wint-conversion] err = ps2_sendbyte(&psmouse->ps2dev, PSMOUSE_CMD_ENABLE, NULL); ^~~~ include/linux/stddef.h:8:14: note: expanded from macro 'NULL' #define NULL ((void *)0) ^~~~~~~~~~~ include/linux/libps2.h:64:63: note: passing argument to parameter 'timeout' here int ps2_sendbyte(struct ps2dev *ps2dev, u8 byte, unsigned int timeout); ^ 2 warnings generated. vim +1509 drivers/input/mouse/elantech.c 1495 1496 /* 1497 * Put the touchpad back into absolute mode when reconnecting 1498 */ 1499 static int elantech_reconnect(struct psmouse *psmouse) 1500 { 1501 psmouse_reset(psmouse); 1502 1503 if (elantech_detect(psmouse, 0)) 1504 return -1; 1505 1506 if (dmi_check_system(elantech_needs_reenable)) { 1507 int err; 1508 > 1509 err = ps2_sendbyte(&psmouse->ps2dev, PSMOUSE_CMD_DISABLE, NULL); 1510 1511 if (err) 1512 psmouse_warn(psmouse, "Failed to deactivate mouse on %s: %d\n", 1513 psmouse->ps2dev.serio->phys, err); 1514 1515 err = ps2_sendbyte(&psmouse->ps2dev, PSMOUSE_CMD_ENABLE, NULL); 1516 1517 if (err) 1518 psmouse_warn(psmouse, "Failed to reactivate mouse on %s: %d\n", 1519 psmouse->ps2dev.serio->phys, err); 1520 } 1521 1522 if (elantech_set_absolute_mode(psmouse)) { 1523 psmouse_err(psmouse, 1524 "failed to put touchpad back into absolute mode.\n"); 1525 return -1; 1526 } 1527 1528 return 0; 1529 } 1530 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
