>> >> - } else
>> >> - if (*rsize == 203 && rdesc[192] == 0x15 && rdesc[193] == 0x0 &&
>> >> + } else if (*rsize == 203 && rdesc[192] == 0x15 && rdesc[193] ==
>> >> +0x0 &&
>> >> rdesc[194] == 0x25 && rdesc[195] == 0x12) {
>> >> samsung_irda_dev_trace(hdev, 203);
>> >> rdesc[193] = 0x1;
>> >> rdesc[195] = 0xf;
>> >> - } else
>> >> - if (*rsize == 135 && rdesc[124] == 0x15 && rdesc[125] == 0x0 &&
>> >> + } else if (*rsize == 135 && rdesc[124] == 0x15 && rdesc[125] ==
>> >> +0x0 &&
>> >> rdesc[126] == 0x25 && rdesc[127] == 0x11) {
>> >> samsung_irda_dev_trace(hdev, 135);
>> >> rdesc[125] = 0x1;
>> >> rdesc[127] = 0xe;
>> >> - } else
>> >> - if (*rsize == 171 && rdesc[160] == 0x15 && rdesc[161] == 0x0 &&
>> >> + } else if (*rsize == 171 && rdesc[160] == 0x15 && rdesc[161] ==
>> >> +0x0 &&
>> >> rdesc[162] == 0x25 && rdesc[163] == 0x01) {
>> >> samsung_irda_dev_trace(hdev, 171);
>> >> rdesc[161] = 0x1;
>> >
>> >For this block, I think a rewrite using memcmp would be clearer.
>> >Something like:
>> Okay . Thanks for your valuable feedback. We will promptly address
>> your suggestions and enhance our code accordingly.
>
>I agree with Joe's suggestion here; are you planning to send v2 of the
series?
>
>The rest of the set looks good to me.
>
>Thanks,
>
>--
>Jiri Kosina
>SUSE Labs
Hello Jiri ,
Yes, I am planning to send the v2 of the series. I will include review
comments and share it with you soon.
Thank & Regards
Sandeep C S
