>On Mon, 2024-01-08 at 14:49 +0530, Sandeep C S wrote:
>> Warning found by checkpatch.pl script.
>[]
>> diff --git a/drivers/hid/hid-samsung.c b/drivers/hid/hid-samsung.c
>[]
>> @@ -67,20 +67,17 @@ static __u8 *samsung_irda_report_fixup(struct
>hid_device *hdev, __u8 *rdesc,
>> rdesc[178] = 0x08;
>> rdesc[180] = 0x06;
>> rdesc[182] = 0x42;
>> - } else
>> - if (*rsize == 203 && rdesc[192] == 0x15 && rdesc[193] == 0x0 &&
>> + } else if (*rsize == 203 && rdesc[192] == 0x15 && rdesc[193] == 0x0
>> +&&
>> rdesc[194] == 0x25 && rdesc[195] == 0x12) {
>> samsung_irda_dev_trace(hdev, 203);
>> rdesc[193] = 0x1;
>> rdesc[195] = 0xf;
>> - } else
>> - if (*rsize == 135 && rdesc[124] == 0x15 && rdesc[125] == 0x0 &&
>> + } else if (*rsize == 135 && rdesc[124] == 0x15 && rdesc[125] == 0x0
>> +&&
>> rdesc[126] == 0x25 && rdesc[127] == 0x11) {
>> samsung_irda_dev_trace(hdev, 135);
>> rdesc[125] = 0x1;
>> rdesc[127] = 0xe;
>> - } else
>> - if (*rsize == 171 && rdesc[160] == 0x15 && rdesc[161] == 0x0 &&
>> + } else if (*rsize == 171 && rdesc[160] == 0x15 && rdesc[161] == 0x0
>> +&&
>> rdesc[162] == 0x25 && rdesc[163] == 0x01) {
>> samsung_irda_dev_trace(hdev, 171);
>> rdesc[161] = 0x1;
>
>For this block, I think a rewrite using memcmp would be clearer.
>Something like:
Okay . Thanks for your valuable feedback. We will promptly address your
suggestions and enhance our code accordingly.
And also please review other patch set as well.
Thank you
>---
> drivers/hid/hid-samsung.c | 34 +++++++++++++++-------------------
> 1 file changed, 15 insertions(+), 19 deletions(-)
>
>diff --git a/drivers/hid/hid-samsung.c b/drivers/hid/hid-samsung.c index
>cf5992e970940..cd84fb5e68f69 100644
>--- a/drivers/hid/hid-samsung.c
>+++ b/drivers/hid/hid-samsung.c
>@@ -58,33 +58,29 @@ static inline void samsung_irda_dev_trace(struct
>hid_device *hdev, static __u8 *samsung_irda_report_fixup(struct hid_device
>*hdev, __u8 *rdesc,
> unsigned int *rsize)
> {
>- if (*rsize == 184 && rdesc[175] == 0x25 && rdesc[176] == 0x40 &&
>- rdesc[177] == 0x75 && rdesc[178] == 0x30 &&
>- rdesc[179] == 0x95 && rdesc[180] == 0x01 &&
>- rdesc[182] == 0x40) {
>+ if (*rsize == 184 &&
>+ !memcmp(&rdesc[175], "\x25\x40\x75\x30\x95\x01", 6) &&
>+ rdesc[182] == 0x40) {
> samsung_irda_dev_trace(hdev, 184);
> rdesc[176] = 0xff;
> rdesc[178] = 0x08;
> rdesc[180] = 0x06;
> rdesc[182] = 0x42;
>- } else
>- if (*rsize == 203 && rdesc[192] == 0x15 && rdesc[193] == 0x0 &&
>- rdesc[194] == 0x25 && rdesc[195] == 0x12) {
>+ } else if (*rsize == 203 &&
>+ !memcmp(&rdesc[192], "\x15\x00\x25\x12", 4)) {
> samsung_irda_dev_trace(hdev, 203);
>- rdesc[193] = 0x1;
>- rdesc[195] = 0xf;
>- } else
>- if (*rsize == 135 && rdesc[124] == 0x15 && rdesc[125] == 0x0 &&
>- rdesc[126] == 0x25 && rdesc[127] == 0x11) {
>+ rdesc[193] = 0x01;
>+ rdesc[195] = 0x0f;
>+ } else if (*rsize == 135 &&
>+ !memcmp(&rdesc[124], "\x15\x00\x25\x11", 4)) {
> samsung_irda_dev_trace(hdev, 135);
>- rdesc[125] = 0x1;
>- rdesc[127] = 0xe;
>- } else
>- if (*rsize == 171 && rdesc[160] == 0x15 && rdesc[161] == 0x0 &&
>- rdesc[162] == 0x25 && rdesc[163] == 0x01) {
>+ rdesc[125] = 0x01;
>+ rdesc[127] = 0x0e;
>+ } else if (*rsize == 171 &&
>+ !memcmp(&rdesc[160], "\x15\x00\x25\x01", 4)) {
> samsung_irda_dev_trace(hdev, 171);
>- rdesc[161] = 0x1;
>- rdesc[163] = 0x3;
>+ rdesc[161] = 0x01;
>+ rdesc[163] = 0x03;
> }
> return rdesc;
> }
