Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> 於 2023年12月30日 週六 下午10:19寫道： > > On 29/12/2023 10:08, Allen Lin wrote: > > Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> 於 2023年12月28日 週四 下午6:36寫道： > >> > >> On 27/12/2023 06:35, Allen_Lin wrote: > >>> Add the HX83102j touchscreen device tree bindings documents. > >>> > >>> Signed-off-by: Allen_Lin <allencl_lin@xxxxxxxxxxx> > >>> --- > >> > >> Where is the changelog? There is no cover letter attached, so changelog > >> is supposed to be here. There were several comments, so does it mean you > >> ignored them? > >> > > Cover letter is not in this mail but in the mail with this title > > "[PATCH v3 0/2] Add HX83102j driver for HIMAX HID touchscreen" > > There was no cover letter attached to this thread. Don't send cover > letters in separate threads. > > > > > Hi, > > This driver implements for Himax HID touchscreen HX83102j. > > > > Using SPI interface to receive/send HID packets. > > > > Patchs notes as below > > 1. Add the Maintainer and devicetree bindings document for driver > > 2. Add the driver code and modify Kconfig/Makefile to support the driver > > > > change in v2 : > > - Fix kernel test robot build warnings. > > change in v3 : > > - Modify code according to review suggesions. > > Not detailed enough. What did you change exactly? > 1. Remove function pointer coding style 2. Remove unused code/variable/structure 3. Use devm_kzalloc() to allocate memory 4. Use gpio descriptors to control gpio 5. All functions are changed to static 6. Drop all global variables. > > Best regards, > Krzysztof > Best regards Allen
