Thanks Tzung-Bi! Best Regards, Even Xu -----Original Message----- From: Tzung-Bi Shih <tzungbi@xxxxxxxxxx> Sent: Wednesday, December 6, 2023 11:33 AM To: Xu, Even <even.xu@xxxxxxxxx> Cc: jikos@xxxxxxxxxx; srinivas.pandruvada@xxxxxxxxxxxxxxx; bleung@xxxxxxxxxxxx; groeck@xxxxxxxxxxxx; linux-input@xxxxxxxxxxxxxxx; chrome-platform@xxxxxxxxxxxxxxx Subject: Re: [PATCH 4/4] platform: chrome: cros_ec_ishtp: use helper functions for connection On Tue, Dec 05, 2023 at 09:50:33AM +0800, Even Xu wrote: > Use helper functions ishtp_cl_establish_connection() and > ishtp_cl_destroy_connection() to establish and destroy connection > respectively. These functions are used during initialization, reset > and deinitialization flows. > > No functional changes are expected. > > Signed-off-by: Even Xu <even.xu@xxxxxxxxx> > Acked-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> Acked-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx> One minor suggestion: we usually use "platform/chrome:" instead of "platform: chrome:" for the title prefix.