There are three ISHTP clients, they have same ISHTP interface to connect, reset and disconnect. Also there are multiple steps for connect, reset and disconnect. Simplify multiple steps by creating two helper functions. This will simplify code flow and also avoid code duplication. Also this removes memory allocation calls during reset, by using these helper functions. No functional changes are expected with this series. Even Xu (4): HID: Intel-ish-hid: Ishtp: Add helper functions for client connection HID: intel-ish-hid: ishtp-hid-client: use helper functions for connection HID: intel-ish-hid: ishtp-fw-loader: use helper functions for connection platform: chrome: cros_ec_ishtp: use helper functions for connection drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 60 ++------- drivers/hid/intel-ish-hid/ishtp-hid-client.c | 63 ++------- drivers/hid/intel-ish-hid/ishtp/client.c | 185 +++++++++++++++++++++++++-- drivers/platform/chrome/cros_ec_ishtp.c | 74 +++-------- include/linux/intel-ish-client-if.h | 3 + 5 files changed, 217 insertions(+), 168 deletions(-) -- 2.7.4