Le 2023-12-05 09:15, Krzysztof Kozlowski a écrit :
On 04/12/2023 15:05, Kamel Bouhara wrote:
Add the TouchNetix axiom I2C touchscreen device tree bindings
documentation.
Signed-off-by: Kamel Bouhara <kamel.bouhara@xxxxxxxxxxx>
+$id:
http://devicetree.org/schemas/input/touchscreen/touchnetix,ax54a.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TouchNetix Axiom series touchscreen controller
+
+maintainers:
+ - Kamel Bouhara <kamel.bouhara@xxxxxxxxxxx>
+
Why you do not have ref to touchscreen? Is it not a touchscreen?
The common properties are not used or applicable here, should I still
ref touchscreen ?
+properties:
+ compatible:
+ const: touchnetix,ax54a
+
+ reg:
+ const: 0x66
+
+ interrupts:
+ maxItems: 1
+
+ reset-gpios:
+ maxItems: 1
+
+ poll-interval:
+ description: Poll interval time in milliseconds.
Missing type or missing ref to input. It seems you want to use existing
property thus no type, but you did not reference input.yaml
Ok is this the right way to do it :
allOf:
- $ref: input.yaml#
properties:
poll-interval: true
+
+ VDDA-supply:
lowercase
+ description: Analog power supply regulator on VDDA pin
+
+ VDDI-supply:
lowercase
Ack.
+ description: I/O power supply regulator on VDDI pin
+
+required:
+ - compatible
+ - reg
Supplies are usually required. Devices rarely can operate without
power.
Indeed, can I still have them optional in the driver ?
I have fixed regulators and Im testing on x86 hence I
would like to avoid having extra acpi code to supply them.
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
Blank line
Ack.
+ touchscreen@66 {
+ compatible = "touchnetix,ax54a";
+ reg = <0x66>;
+ interrupt-parent = <&gpio2>;
+ interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
+ reset-gpios = <&gpio1 1 GPIO_ACTIVE_HIGH>;
+ };
Best regards,
Krzysztof
Thanks
--
Kamel Bouhara, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
