On 04/12/2023 15:05, Kamel Bouhara wrote: > Add the TouchNetix axiom I2C touchscreen device tree bindings > documentation. > > Signed-off-by: Kamel Bouhara <kamel.bouhara@xxxxxxxxxxx> > +$id: http://devicetree.org/schemas/input/touchscreen/touchnetix,ax54a.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: TouchNetix Axiom series touchscreen controller > + > +maintainers: > + - Kamel Bouhara <kamel.bouhara@xxxxxxxxxxx> > + Why you do not have ref to touchscreen? Is it not a touchscreen? > +properties: > + compatible: > + const: touchnetix,ax54a > + > + reg: > + const: 0x66 > + > + interrupts: > + maxItems: 1 > + > + reset-gpios: > + maxItems: 1 > + > + poll-interval: > + description: Poll interval time in milliseconds. Missing type or missing ref to input. It seems you want to use existing property thus no type, but you did not reference input.yaml > + > + VDDA-supply: lowercase > + description: Analog power supply regulator on VDDA pin > + > + VDDI-supply: lowercase > + description: I/O power supply regulator on VDDI pin > + > +required: > + - compatible > + - reg Supplies are usually required. Devices rarely can operate without power. > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; Blank line > + touchscreen@66 { > + compatible = "touchnetix,ax54a"; > + reg = <0x66>; > + interrupt-parent = <&gpio2>; > + interrupts = <2 IRQ_TYPE_EDGE_FALLING>; > + reset-gpios = <&gpio1 1 GPIO_ACTIVE_HIGH>; > + }; Best regards, Krzysztof
