On 7/27/2023 4:29 PM, Krzysztof Kozlowski wrote:
On 27/07/2023 09:54, Fenglin Wu wrote:
+ - enum:
+ - qcom,pm7550ba-vib
+ - const: qcom,pm7325b-vib
Yes
I wonder why this approved change turned out to something incorrect in
your v3 patch...
Since I got review comments in the driver change and I was told to
refactor the driver before adding new HW support. I added the HW type
logic in the driver and I was thinking it might be good to add some
generic compatible strings to match with the HW type introduced in the
driver change.
Anyway, I will update it to what you suggested in next patch.
Drivers are not really related to bindings, so whatever HW type you add
in driver, is not a reason to change bindings. Reason to change bindings
could be for example: because hardware is like that.
Understood.
Sorry, I forgot to mention, in v3, I added the 'reg' value to the
register offset and no longer hard code the 16-bit register address,
that makes the vibrators inside PMI632/PM7250B/PM7325B/PM7550BA all
compatible, and that was another motivation of adding a generic
compatible string and make the others as the fallback.
This will be still the case in v4, I might keep it similar in v3 but
just drop "qcom,spmi-vib-gen1"
Best regards,
Krzysztof
