On 7/18/2023 2:38 PM, Fenglin Wu wrote:
On 7/18/2023 2:33 PM, Krzysztof Kozlowski wrote:
On 18/07/2023 08:26, Fenglin Wu wrote:
Add support for vibrator module inside Qualcomm PMI632, PM7250B, PM7325B
PMICs.
Signed-off-by: Fenglin Wu <quic_fenglinw@xxxxxxxxxxx>
---
I don't see changelog. No changes then?
Sorry, I updated the change log in the cover letter which didn't seems
to be sent to a wider audience, I will resend it by adding more
receivers in the to list
Fenglin
Just FYI,the change log was updated in the cover letter here:
https://lore.kernel.org/linux-arm-msm/20230718062639.2339589-1-quic_fenglinw@xxxxxxxxxxx/T/#m3819b50503ef19e0933a10bf797351a4af35537f
Also the commit text and the driver change were also updated accordingly
to address your review comment by removing 'pm7550ba-vib' compatible string.
Since the changes are receiving review comments, I will not resend it. I
will add a larger to-list when pushing the next patchset.
Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git
a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml
b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml
index c8832cd0d7da..481163105d24 100644
--- a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml
+++ b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml
@@ -15,6 +15,9 @@ properties:
- qcom,pm8058-vib
- qcom,pm8916-vib
- qcom,pm8921-vib
+ - qcom,pmi632-vib
+ - qcom,pm7250b-vib
+ - qcom,pm7325b-vib
Not much improved. With missing changelog, it seems you ignored the
feedback.
Best regards,
Krzysztof
