> -----Original Message----- > From: Mark Brown <broonie@xxxxxxxxxx> > Sent: Monday, July 17, 2023 7:16 PM > To: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>; Mike Looijmans > <mike.looijmans@xxxxxxxx>; Andreas Helbech Kleist > <andreaskleist@xxxxxxxxx>; Geert Uytterhoeven <geert+renesas@xxxxxxxxx>; > Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>; linux- > input@xxxxxxxxxxxxxxx; Prabhakar Mahadev Lad <prabhakar.mahadev- > lad.rj@xxxxxxxxxxxxxx>; linux-renesas-soc@xxxxxxxxxxxxxxx; Wolfram Sang > <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > Subject: Re: [PATCH v2 1/2] Input: exc3000 - Simplify probe() > > On Mon, Jul 17, 2023 at 04:35:02PM +0000, Biju Das wrote: > > > The .device_get_match_data callbacks are missing for I2C and SPI bus > subsystems. > > Can you please throw some lights on this? > > It's the first time I've ever heard of that callback, I don't know why > whoever added it wouldn't have done those buses in particular or if it > just didn't happen. Try adding it and if it works send the patches? I need to investigate at some point later, Currently only OF and ACPI have these callbacks. [1] https://elixir.bootlin.com/linux/v6.0-rc4/source/drivers/of/property.c#L1507 [2] https://elixir.bootlin.com/linux/v6.0-rc4/source/drivers/acpi/property.c#L1587 Cheers, Biju