Hi Biju, On Mon, Jul 17, 2023 at 02:17:55PM +0100, Biju Das wrote: > The exc3000_id.driver_data could store a pointer to the info, > like for ACPI/DT-based matching, making I2C, ACPI and DT-based > matching more similar. > > After that, we can simplify the probe() by replacing device_get_ > match_data() and i2c_match_id() by i2c_get_match_data() as we have > similar I2C, ACPI and DT-based matching table. Have you considered enhancing device_get_match_data() to allow for bus-specific "get_match_data" implementations? This way the drivers would simply call device_get_match_data() and not care if they are I2C, SPI, or something else... Thanks. -- Dmitry