On Wed, Jul 05, 2023 at 11:28:45PM +0200, Sebastian Reichel wrote: > Hi, > > On Wed, Jul 05, 2023 at 12:28:50PM -0700, Dmitry Torokhov wrote: > > On Tue, Jul 04, 2023 at 02:08:21AM +0200, Sebastian Reichel wrote: > > > Hi, > > > > > > On Mon, Jul 03, 2023 at 04:00:05PM -0700, Randy Dunlap wrote: > > > > Change the beginning "/**" in the file to "/*" since it is not a > > > > kernel-doc comment. This prevents a kernel-doc warning: > > > > > > > > drivers/input/misc/cpcap-pwrbutton.c:2: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst > > > > * CPCAP Power Button Input Driver > > > > > > > > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > > > > Cc: Sebastian Reichel <sre@xxxxxxxxxx> > > > > Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > > > > Cc: linux-input@xxxxxxxxxxxxxxx > > > > --- > > > > > > Reviewed-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> > > > > Applied, thank you. > > > > BTW, the driver is missing SPDX annotation, Sebastian I wonder if you > > could send a patch addressing this (given you are the author it is > > better coming from you). > > DONE: https://lore.kernel.org/all/20230705212231.631525-1-sre@xxxxxxxxxx/ Thank you, much appreciated. -- Dmitry