On Sun, Jun 04, 2023 at 10:14:52PM +0300, Nikita Shubin wrote: > On Thu, 2023-06-01 at 19:54 +0300, Andy Shevchenko wrote: > > On Thu, Jun 01, 2023 at 08:45:33AM +0300, Nikita Shubin wrote: ... > > > +static int ep93xx_keypad_flags; > > > +module_param(ep93xx_keypad_flags, int, 0); > > > +MODULE_PARM_DESC(ep93xx_keypad_flags, "EP93XX keypad flags."); > > > > Why? This pretty much looks like missing DT description. > > From other patches from this series, i learned NOT to add new DT > entities, not even with vendor prefix, no way! > > May be i missing something of course... We do not add module parameters to a new code either. So this will be a dead end. ... > Was never used in different ways than initializing all to zeroes > including flags since 2.6 (didn't look before through), so i would > prefer to drop this completely than moving it into device tree. This sounds the best! -- With Best Regards, Andy Shevchenko
