Hello Andy! On Thu, 2023-06-01 at 19:54 +0300, Andy Shevchenko wrote: > On Thu, Jun 01, 2023 at 08:45:33AM +0300, Nikita Shubin wrote: > > - get keymap from the device tree > > - find register range from the device tree > > - get interrupts from device tree > > ... > > > +/* flags for the ep93xx_keypad driver */ > > +#define EP93XX_KEYPAD_DISABLE_3_KEY (1<<0) /* disable 3-key > > reset */ > > +#define EP93XX_KEYPAD_DIAG_MODE (1<<1) /* > > diagnostic mode */ > > +#define EP93XX_KEYPAD_BACK_DRIVE (1<<2) /* back driving > > mode */ > > +#define EP93XX_KEYPAD_TEST_MODE (1<<3) /* scan > > only column 0 */ > > +#define EP93XX_KEYPAD_AUTOREPEAT (1<<4) /* enable key > > autorepeat */ > > > +static int ep93xx_keypad_flags; > > +module_param(ep93xx_keypad_flags, int, 0); > > +MODULE_PARM_DESC(ep93xx_keypad_flags, "EP93XX keypad flags."); > > Why? This pretty much looks like missing DT description. >From other patches from this series, i learned NOT to add new DT entities, not even with vendor prefix, no way! May be i missing something of course... Either way https://elixir.bootlin.com/linux/v6.4-rc4/source/arch/arm/mach-ep93xx/core.c#L577 static struct ep93xx_keypad_platform_data ep93xx_keypad_data; Was never used in different ways than initializing all to zeroes including flags since 2.6 (didn't look before through), so i would prefer to drop this completely than moving it into device tree. May we should drop ep93xx_keypad entirely, i don't have hardware to test it anyway, neither does Alexander. > > Please, write your commit message better, so we can understand the > point of > such decisions w/o asking. >
