Hi Randy, Thanks for the feedback. You are correct about the styling issue in my patch. I will fix this. I do want to bring to attention that there seem to be a couple of kernel config options in the Kconfig file for the hid subsystem that currently violate the styling rules. It probably would make sense to have a clean-up patch for this issue overall (separate from this patch, which I will correct in my next version). -- Rahul Rameshbabu On Mon, 17 Apr, 2023 12:20:51 -0700 Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: > According to Documentation/process/coding-style.rst, Kconfig help text should > be indented by 2 spaces after the "help" line: > > 10) Kconfig configuration files > ------------------------------- > > For all of the Kconfig* configuration files throughout the source tree, > the indentation is somewhat different. Lines under a ``config`` definition > are indented with one tab, while help text is indented an additional two > spaces. Example:: > > config AUDIT > bool "Auditing support" > depends on NET > help > Enable auditing infrastructure that can be used with another > kernel subsystem, such as SELinux (which requires this for > logging of avc messages output). Does not do system-call > auditing without CONFIG_AUDITSYSCALL.