Following up on this since it has been a while since the last attempt. I'm still hoping to get this patch merged if possible :) The patch still applies cleanly against the for-6.4/core branch and the hid-tools test suite still runs without any (new*) test failures when the patch is applied. Please let me know if there's anything I could / should do to continue moving this forward. *There are four failures in test_sony.py, but they occur on the for-6.4/core branch regardless of if the patch is applied or not. Jason --- Now instead of four in the eights place / you’ve got three, ‘Cause you added one / (That is to say, eight) to the two, / But you can’t take seven from three, / So you look at the sixty-fours.... On Thu, Dec 15, 2022 at 8:11 AM Jason Gerecke <killertofu@xxxxxxxxx> wrote: > > Thanks for the response, Jose. > > Unfortunately this isn't an issue that we can fix in the Wacom driver > since it affects devices that don't use the Wacom driver. While we > could theoretically adopt affected VID:PIDs into the Wacom driver on a > case-by-case basis, there would be a large time lag between us > adopting a device and users running the required kernel. This should > really be something that is fixed in the hid-generic driver, even if > it means some pain trying to ensure we don't break things in the > process... I'm still hoping to hear something back from Benjamin about > my hid-tools test results or if additional testing is needed. > > Jason > --- > Now instead of four in the eights place / > you’ve got three, ‘Cause you added one / > (That is to say, eight) to the two, / > But you can’t take seven from three, / > So you look at the sixty-fours.... > > On Sat, Dec 3, 2022 at 3:43 AM José Expósito <jose.exposito89@xxxxxxxxx> wrote: > > > > Hi Jason, > > > > > Still waiting to hear back about this. Are positive results from the > > > hid-tools tests sufficient, or is there additional work that should be > > > done for this patch? > > > > A while ago a similar patch was sent [1] and it was in a similar status > > to your patch for a while, so I decided to fix the issue in the UCLogic > > driver [2]. > > > > I can not tell you if this patch needs additional work, but you might be > > interested in fixing it in the Wacom driver, where it'd be easier for you > > to test that no regressions are introduced. > > > > I hope this helps a bit, > > Jose > > > > [1] https://lore.kernel.org/linux-input/20220804151832.30373-1-openglfreak@xxxxxxxxxxxxxx/ > > [2] https://lore.kernel.org/linux-input/d08049f2-443b-f769-cfde-629cdfb96fc0@xxxxxxxxxxxxxx/T/
